From 9082d36ddf6d38e38216a1d9c6e7d85726a31365 Mon Sep 17 00:00:00 2001 From: Magdy Saleh <17618143+magdyksaleh@users.noreply.github.com> Date: Tue, 12 Nov 2024 19:38:59 +0000 Subject: [PATCH] Fix top_p to allow setting it to 1.0 (#676) --- router/src/validation.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/router/src/validation.rs b/router/src/validation.rs index 2950f63f4..34c564541 100644 --- a/router/src/validation.rs +++ b/router/src/validation.rs @@ -277,7 +277,7 @@ impl Validation { // for the user let top_p = top_p .map(|value| { - if value <= 0.0 || value >= 1.0 { + if value <= 0.0 || value > 1.0 { return Err(ValidationError::TopP); } Ok(value) @@ -884,7 +884,7 @@ mod tests { GenerateRequest { inputs: "Hello".to_string(), parameters: GenerateParameters { - top_p: Some(1.0), + top_p: Some(1.1), ..default_parameters() }, add_special_tokens: true,