Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support repetition_penalty in OpenAI API #287

Closed
prd-tuong-nguyen opened this issue Feb 28, 2024 · 2 comments · Fixed by #288
Closed

Support repetition_penalty in OpenAI API #287

prd-tuong-nguyen opened this issue Feb 28, 2024 · 2 comments · Fixed by #288
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prd-tuong-nguyen
Copy link

Feature request

Support repetition_penalty in OpenAI compaitaple API

Motivation

It's really important parameters, currently not support in OpenAI compaitaple API

Your contribution

.
@huytuong010101
Copy link
Contributor

@tgaddair Please help me check this PR: #288

@tgaddair tgaddair mentioned this issue Feb 28, 2024
Merged
@tgaddair
Copy link
Contributor

Thanks for the PR @huytuong010101. Just to confirm: the ask here is to support OpenAI's presence_penalty and map it to LoRAX's repetition_penalty correct?

@tgaddair tgaddair added enhancement New feature or request good first issue Good for newcomers labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add repetition_penalty and top_k to openai
3 participants
@tgaddair @huytuong010101 @prd-tuong-nguyen