Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend uniquepackagemap with useful functions #3218

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: extend uniquepackagemap with useful functions #3218

wants to merge 5 commits into from
+316 −117

Conversation

ruben-arts
Copy link
Contributor

This PR pulls some refactors out of the menuinst PR to easy the addition of more features to pixi global.

Hofer-Julian
Hofer-Julian reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_trampoline_new_activation_scripts is failing with your changes.
I can reproduce this failure locally and it doesn't happen on main

src/cli/global/install.rs Outdated
@@ -162,31 +165,55 @@ async fn setup_environment(
) -> miette::Result<StateChanges> {
let mut state_changes = StateChanges::new_with_env(env_name.clone());

// Check if the environment already exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment seems at the wrong position :)

@ruben-arts
Copy link
Contributor Author

@Hofer-Julian I figured out why the tests fail. But I feel like it's actually a fix, interested in your opinion:

Previously this would happen:

> pixi install -c blabla randompkg
# Installed randompkg from blabla

> pixi install randompkg==2.3.4 --force-reinstall
# Install randompkg from the blabla channel (keeping state as it reused the instance of the previous call)

Now:

> pixi install -c blabla randompkg
# Installed randompkg from blabla

> pixi install randompkg==2.3.4 --force-reinstall
# Install randompkg from the default channels on your machine, overwriting the manifests version of randompkg.

I believe the new version is correct as I would expect --force-reinstall to behave like a remove and install in one. LMKWYT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-arts @Hofer-Julian