Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI #408

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Refactor CI #408

merged 1 commit into from
Dec 13, 2023

Conversation

pavelzw
Copy link
Collaborator

@pavelzw pavelzw commented Dec 8, 2023

This is an attempt to make the CI pipeline easier to read.

Notable changes:

  • hardcode all non-changing things (like PROJECT_NAME) for easier readability
  • use more github jinja instead of bash variables since they are evaluated directly when looking at the CI logs
  • use rust cache for compiling
  • don't strip debug information (they should already not be included when compiling with --release, right?)
  • put fmt, clippy in the same workflow
  • add aarch64-unknown-linux-musl
  • switch from x86_64-unknown-linux-gnu to x86_64-unknown-linux-musl (as in pixi)
  • move away from deprecated actions-rs/* actions

@pavelzw
Copy link
Collaborator Author

pavelzw commented Dec 9, 2023

Any ideas on why the aarch-unknown-linux-musl test is failing? Seems to be failing here:

GitSource::create(
GitUrl::Path("../rattler-build".parse().unwrap()),
"".to_owned(),
None,
vec![],
None,
false,
),
"rattler-build",
),
];
for (source, repo_name) in cases {
let path = git_src(
&source,
cache_dir.as_ref(),
// TODO: this test assumes current dir is the root folder of the project which may
// not be necessary for local runs.
std::env::current_dir().unwrap().as_ref(),
)
.unwrap();

Maybe the .git directory is not mounted correctly in the cross container?

@pavelzw
Copy link
Collaborator Author

pavelzw commented Dec 13, 2023

Didn't manage to reproduce the failing test locally, let's keep aarch64 tests deactivated for now.

@wolfv wolfv merged commit 95a5ede into prefix-dev:main Dec 13, 2023
10 checks passed
@wolfv
Copy link
Member

wolfv commented Dec 13, 2023

thanks!

@pavelzw pavelzw deleted the rework-ci branch December 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants