Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Correct padding issues #10

Open
rootwork opened this issue Jun 17, 2022 · 2 comments
Open

bug: Correct padding issues #10

rootwork opened this issue Jun 17, 2022 · 2 comments
Labels
good first issue Beginner-friendly issue for people wanting to contribute to this project. help wanted We need some extra helping hands or expertise in order to resolve this! Type: Bug Problems in the program which will cause issues for users or implementors. x-Bot: No Abandonment This will never be marked abandoned by the status bot.

Comments

@rootwork
Copy link
Member

rootwork commented Jun 17, 2022

MJML Bullet List version

1.2.2

MJML version

4.12.0

What operating system are you using?

Linux

Node version

v12.22.1

npm or yarn version

6.14.12

Current behavior

There are two things happening here, one a bug (I'm guessing due to internal MJML changes) and one a documentation issue.

First, left-side padding is being duplicated on two different containing <td>s in the bullet list (<mj-list> item), e.g. specify 5px of padding and you'll get 5+5=10px padding. This may occur with padding on other sides as well.

Possibly related, it looks like there's some default bottom padding on the bullet list, but this may be theming-specific.

Second, the documentation page at https://premail.dev/docs/components/mjml-bullet-list does not list default left-padding, whereas the documentation at https://github.com/premail/mjml-bullet-list (correctly) does. Once the bugs are addressed, these need to be aligned.

Expected behavior

Padding is what we ask it to be, and no more.

Steps to reproduce

This can be reproduced using the examples in the repo.

Other information

Since this wasn't occurring before and there have been no updates here, I strongly suspect this is some kind of change in MJML itself, so will need to research that.

@rootwork rootwork added the Type: Bug Problems in the program which will cause issues for users or implementors. label Jun 17, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it is being marked as stale.

Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍

Because this issue is marked as stale, it will be closed and locked in 10 days if no further activity occurs. If you want to prevent it from being closed, just leave a comment.

Thank you for your contributions!

@github-actions github-actions bot added the Status: Stale No recent activity. label Sep 16, 2022
@rootwork rootwork added x-Bot: No Abandonment This will never be marked abandoned by the status bot. good first issue Beginner-friendly issue for people wanting to contribute to this project. help wanted We need some extra helping hands or expertise in order to resolve this! and removed Status: Stale No recent activity. labels Sep 16, 2022
@rootwork
Copy link
Member Author

Setting to not abandon as this is still an issue and hasn't yet been addressed -- and given that, adding some tags to invite others to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Beginner-friendly issue for people wanting to contribute to this project. help wanted We need some extra helping hands or expertise in order to resolve this! Type: Bug Problems in the program which will cause issues for users or implementors. x-Bot: No Abandonment This will never be marked abandoned by the status bot.
Projects
None yet
Development

No branches or pull requests

1 participant