bug: Correct padding issues #10
Labels
good first issue
Beginner-friendly issue for people wanting to contribute to this project.
help wanted
We need some extra helping hands or expertise in order to resolve this!
Type: Bug
Problems in the program which will cause issues for users or implementors.
x-Bot: No Abandonment
This will never be marked abandoned by the status bot.
MJML Bullet List version
1.2.2
MJML version
4.12.0
What operating system are you using?
Linux
Node version
v12.22.1
npm or yarn version
6.14.12
Current behavior
There are two things happening here, one a bug (I'm guessing due to internal MJML changes) and one a documentation issue.
First, left-side padding is being duplicated on two different containing
<td>
s in the bullet list (<mj-list>
item), e.g. specify 5px of padding and you'll get 5+5=10px padding. This may occur with padding on other sides as well.Possibly related, it looks like there's some default bottom padding on the bullet list, but this may be theming-specific.
Second, the documentation page at https://premail.dev/docs/components/mjml-bullet-list does not list default left-padding, whereas the documentation at https://github.com/premail/mjml-bullet-list (correctly) does. Once the bugs are addressed, these need to be aligned.
Expected behavior
Padding is what we ask it to be, and no more.
Steps to reproduce
This can be reproduced using the examples in the repo.
Other information
Since this wasn't occurring before and there have been no updates here, I strongly suspect this is some kind of change in MJML itself, so will need to research that.
The text was updated successfully, but these errors were encountered: