Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating testing-mysql-server-8 for prestodb #23

Open
Akanksha-kedia opened this issue Jan 3, 2024 · 8 comments
Open

Creating testing-mysql-server-8 for prestodb #23

Akanksha-kedia opened this issue Jan 3, 2024 · 8 comments

Comments

@Akanksha-kedia
Copy link

Update MySQL JDBC driver to 8.2.0

Note: This artifact was moved to:

com.mysql » mysql-connector-j

MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

image

The upgrade is necessary due to the discovery of direct vulnerabilities in the earlier version of the driver, as listed below:
Direct vulnerabilities:
CVE-2022-21363
CVE-2019-2692
CVE-2018-3258

Impact
The component impacted by this update is presto-mysql. However, the impact is not significant and should not affect the overall functionality or performance.

link : prestodb/presto#21541

Motivation : Need a new version of this dependency for version 8 so PRESTODB tests and prod are consistent.

@Akanksha-kedia
Copy link
Author

Screenshot 2024-01-03 at 9 55 26 AM M1 mac

@Akanksha-kedia
Copy link
Author

@tdcmeehan
Copy link
Contributor

This looks like an issue on your Mac setup and may require some deep debugging.

@Akanksha-kedia
Copy link
Author

@agrawalreetika prestodb/presto#21845 i have raised issue and was working on it, please review and comment.

@ZacBlanco
Copy link
Contributor

PR #24 for the java 21 upgrade fixes the build script and increases the mysql version to 8.4.2.

@agrawalreetika
Copy link
Member

Hi @ZacBlanco Just wanted to confirm with Java 21 upgrade we are covering MySQL upgrade for both presto and MySQL testing server repos?

prestodb/presto#21845

@ZacBlanco
Copy link
Contributor

I haven't tested moving the mysql driver version higher yet. I think I think as part of the upgrade work we are trying to minimize the footprint as much as possible. If we find that we must pull up mysql to get tests passing, then we will do it

@agrawalreetika
Copy link
Member

Sounds good then may be once testing-mysql-server is upgraded we can then do drive upgrade in presto repo as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants