Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with modern on Msys2 and Cygwin fails #2057

Open
hedara90 opened this issue Oct 28, 2024 · 3 comments
Open

Building with modern on Msys2 and Cygwin fails #2057

hedara90 opened this issue Oct 28, 2024 · 3 comments

Comments

@hedara90
Copy link

Using make modern on Msys2 and Cygwin makes the build fail with:

data/mystery_gift.s:18: error: include/constants/rematches.h:4: empty enum is invalid
make: *** [Makefile:347: build/modern/data/mystery_gift.o] Error 1
make: *** Deleting file 'build/modern/data/mystery_gift.o'

Good commit: a3d5f54
Bad commit: 3f49c5c

Building with make modern on other systems doesn't fail.

@singulocity
Copy link

Also happening on my end. Just stumbled upon your issue while searching for a solution...

@GriffinRichards
Copy link
Member

This is a problem with how preproc is handling enums for assembly files. You can see a discussion about possible solutions here. No one has been bothered enough to open a PR to fix this yet (feel free to do so!)

@singulocity
Copy link

Thanks! I did discover a workaround by putting the enum on one line, haha

I'll take a look at that and if I am confident enough I'll try a PR. I've been using this project as a fun way to learn C!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants