diff --git a/PreviousNextDrupal/ruleset.xml b/PreviousNextDrupal/ruleset.xml index 09b1e7a..351bfe4 100644 --- a/PreviousNextDrupal/ruleset.xml +++ b/PreviousNextDrupal/ruleset.xml @@ -42,6 +42,7 @@ + 0 0 diff --git a/README.md b/README.md index de30926..7eb591d 100644 --- a/README.md +++ b/README.md @@ -161,6 +161,10 @@ Developers are entrusted to properly self-describe code. Suggestions to improve This rule has trouble with newer PHP syntax, especially expression throwables. In any case this rule is best enforced with static analysis. +#### SlevomatCodingStandard.TypeHints.ReturnTypeHint.UselessAnnotation + +This rule is too greedy about what it thinks is 'useless'. Unique detail is removed. + --- _Drupal is a registered trademark of Dries Buytaert._ diff --git a/tests/Sniffs/ReturnTypeHintTest.php b/tests/Sniffs/ReturnTypeHintTest.php index 3656182..2932611 100644 --- a/tests/Sniffs/ReturnTypeHintTest.php +++ b/tests/Sniffs/ReturnTypeHintTest.php @@ -4,8 +4,6 @@ namespace PreviousNext\CodingStandard\Tests\Sniffs; -use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSniff; - /** * @covers \SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSniff * @see https://github.com/slevomat/coding-standard/blob/master/doc/type-hints.md#slevomatcodingstandardtypehintsreturntypehint- @@ -28,17 +26,6 @@ public function testIgnoreTraversable(): void { self::assertNoSniffError($report, 8); } - public function testUseless(): void { - $report = self::checkFile(__DIR__ . '/fixtures/ReturnTypeHintUseless.php'); - self::assertSniffError($report, 8, code: ReturnTypeHintSniff::CODE_USELESS_ANNOTATION); - } - - public function testUselessWithDescription(): void { - $report = self::checkFile(__DIR__ . '/fixtures/ReturnTypeHintUselessWithDescription.php'); - self::assertSame(0, $report->getErrorCount()); - self::assertNoSniffError($report, 8); - } - protected static function getSniffName(): string { return 'SlevomatCodingStandard.TypeHints.ReturnTypeHint'; } diff --git a/tests/Sniffs/fixtures/ReturnTypeHintUseless.php b/tests/Sniffs/fixtures/ReturnTypeHintUseless.php deleted file mode 100644 index 8f57d33..0000000 --- a/tests/Sniffs/fixtures/ReturnTypeHintUseless.php +++ /dev/null @@ -1,12 +0,0 @@ -