diff --git a/common/changes/pcln-design-system/bug-air-61698_2024-03-05-18-44.json b/common/changes/pcln-design-system/bug-air-61698_2024-03-05-18-44.json new file mode 100644 index 0000000000..c32d7f6c6f --- /dev/null +++ b/common/changes/pcln-design-system/bug-air-61698_2024-03-05-18-44.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "pcln-design-system", + "comment": "bug fix for when spinner doesn't spin on mobile devices", + "type": "patch" + } + ], + "packageName": "pcln-design-system" +} \ No newline at end of file diff --git a/packages/core/src/Animate/Animate.stories.tsx b/packages/core/src/Animate/Animate.stories.tsx index 70ad988b53..e43eecd7f9 100644 --- a/packages/core/src/Animate/Animate.stories.tsx +++ b/packages/core/src/Animate/Animate.stories.tsx @@ -173,3 +173,13 @@ export const ComposedAnimations = () => { ) } + +export const SpinAnimation = () => { + return ( + + + + + + ) +} diff --git a/packages/core/src/Animate/Animate.tsx b/packages/core/src/Animate/Animate.tsx index ba5c2a7c6f..8e84135689 100644 --- a/packages/core/src/Animate/Animate.tsx +++ b/packages/core/src/Animate/Animate.tsx @@ -37,6 +37,7 @@ export type MotionVariant = | 'slideOutBottom' | 'slideOutRight' | 'slideInRight' + | 'spin' /** * @public @@ -114,6 +115,10 @@ export const MotionVariants: Record> = { initial: { opacity: 1, y: 0 }, animate: { opacity: 0, y: '100%' }, }, + spin: { + animate: { rotate: 360, height: 'auto' }, + transition: { duration: 1, repeat: Infinity, ease: 'linear' }, + }, } /** diff --git a/packages/core/src/Spinner/Spinner.stories.tsx b/packages/core/src/Spinner/Spinner.stories.tsx index e77c0e785d..26cd9b3b67 100644 --- a/packages/core/src/Spinner/Spinner.stories.tsx +++ b/packages/core/src/Spinner/Spinner.stories.tsx @@ -66,3 +66,9 @@ WithGradientCustomWidth.args = { useGradient: true, strokeWidth: '10px', } + +export const WithGradientDifferentSize = Template.bind({}) +WithGradientDifferentSize.args = { + size: 'medium', + useGradient: true, +} diff --git a/packages/core/src/Spinner/Spinner.tsx b/packages/core/src/Spinner/Spinner.tsx index 49f2e1c3b7..2a2045086c 100644 --- a/packages/core/src/Spinner/Spinner.tsx +++ b/packages/core/src/Spinner/Spinner.tsx @@ -5,6 +5,7 @@ import { Absolute } from '../Absolute/Absolute' import { Flex } from '../Flex/Flex' import { PaletteFamilyName } from '../theme/theme' import { applySizes, getPaletteColor } from '../utils/utils' +import { Animate } from './../Animate/Animate' const sizes = { small: css` @@ -75,40 +76,42 @@ type GradientRingProps = { function GradientRing({ strokeWidth = '6px', ...props }: GradientRingProps) { const strokeColor = getPaletteColor(props.color, 'base')(props) return ( - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + {/* - + /> */} + + ) }