diff --git a/common/changes/pcln-design-system/task-HTL-111365-fix-props-override-for-collapse-and-close_2024-11-08-16-49.json b/common/changes/pcln-design-system/task-HTL-111365-fix-props-override-for-collapse-and-close_2024-11-08-16-49.json new file mode 100644 index 000000000..5249eaf5e --- /dev/null +++ b/common/changes/pcln-design-system/task-HTL-111365-fix-props-override-for-collapse-and-close_2024-11-08-16-49.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "pcln-design-system", + "comment": "Fix storybook buttons", + "type": "minor" + } + ], + "packageName": "pcln-design-system" +} \ No newline at end of file diff --git a/packages/core/src/Drawer/Drawer.stories.tsx b/packages/core/src/Drawer/Drawer.stories.tsx index f03b5282e..d21c0ca45 100644 --- a/packages/core/src/Drawer/Drawer.stories.tsx +++ b/packages/core/src/Drawer/Drawer.stories.tsx @@ -21,9 +21,9 @@ function DrawerStory(props) { heading='Header' isOpen={isOpen} isCollapsed={isCollapsed} + {...props} onClose={includeCloseButton ? () => setIsOpen(false) : undefined} onCollapse={includeCollapseButton ? () => setIsCollapsed((isCollapsed) => !isCollapsed) : undefined} - {...props} > {props.children} diff --git a/packages/core/src/Drawer/Drawer.tsx b/packages/core/src/Drawer/Drawer.tsx index 60db1f1dc..c80fcd1c9 100644 --- a/packages/core/src/Drawer/Drawer.tsx +++ b/packages/core/src/Drawer/Drawer.tsx @@ -79,8 +79,8 @@ export const Drawer: React.FC = ({ maxHeight={isMobile ? ['290px', '400px', '480px', 'calc(100vh - 64px)'] : props.height ?? '100%'} maxWidth={isMobile ? '100%' : ['400px', '600px', '800px', '100%']} width={isMobile ? '100%' : props.width} - height={!isCollapsed && props.height ? props.height : 'fit-content'} {...props} + height={!isCollapsed && props.height ? props.height : 'fit-content'} >