Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating: Missing cancel input in component #17210

Open
1 of 4 tasks
itismohammadreza opened this issue Dec 25, 2024 · 0 comments
Open
1 of 4 tasks

Rating: Missing cancel input in component #17210

itismohammadreza opened this issue Dec 25, 2024 · 0 comments
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior
Milestone

Comments

@itismohammadreza
Copy link
Contributor

Describe the bug

The Rating component documentation mentions the cancelIcon and onCancel inputs/outputs. However, it seems that the following inputs have been removed:

  • cancel
  • iconCancelStyle
  • iconCancelClass

These inputs were available and functional in previous versions

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/kycanndj?file=src%2Fapp%2Frating-basic-demo.ts,src%2Fapp%2Frating-basic-demo.html

Environment

windows

Angular version

19.0.0

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

it is no longer possible to bind the following inputs:

-cancel
-iconCancelStyle
-iconCancelClass

Expected behavior

The Rating component should support the following inputs as it did in previous versions:

cancel: A boolean input to enable or disable the cancel functionality.
iconCancelStyle: A style object to customize the appearance of the cancel icon.
iconCancelClass: A class string to apply custom CSS classes to the cancel icon.

@itismohammadreza itismohammadreza added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 25, 2024
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 19.0.2, 19.0.4 Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior
Projects
Status: Review
Development

No branches or pull requests

3 participants