Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover Close Button #17240

Open
1 of 4 tasks
vcucchiara opened this issue Dec 28, 2024 · 1 comment
Open
1 of 4 tasks

Popover Close Button #17240

vcucchiara opened this issue Dec 28, 2024 · 1 comment
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@vcucchiara
Copy link

Describe the bug

Converted from v16 OverlayPanel to v18 Popover. ShowCloseIcon is not working anymore. It used to be a round X over the corner of the overlay.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-bqqgdogj?file=src%2Fapp%2Fapp.component.html

Environment

Angular 18 PrimeNG 18 with tailwind.css. WSL2 on windows. Easily reproduced on stackblitz template

Angular version

18

PrimeNG version

v18 (LTS Only)

Node version

22.12.0

Browser(s)

Chrome

Steps to reproduce the behavior

Click on the PrimeNG button in the stackblitz template and observe the popover with no close button

Expected behavior

A close button is added to the popover

@vcucchiara vcucchiara added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 28, 2024
@mertsincan mertsincan added this to the 19.0.3 milestone Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 30, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 30, 2024
@hakimio
Copy link

hakimio commented Jan 2, 2025

Documentation lists showCloseIcon input property, but the input doesn't exist in the implementation of the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

4 participants