Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog component #17245

Open
4 tasks
mohamedelsayedhussein opened this issue Dec 29, 2024 · 0 comments
Open
4 tasks

dialog component #17245

mohamedelsayedhussein opened this issue Dec 29, 2024 · 0 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
19.0.3

Comments

@mohamedelsayedhussein
Copy link

Describe the bug

If showHeader flag is set to false, it doesn't hide the dialog header in p-dialog component, however it works fine in dynamic dialog

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/

Environment

angular version 19.0.5
node version 22.12.0
primeng 19.0.2

Angular version

19.0.5

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Wrap header teplmate inside a condition that resolves only if showHeder was true

Expected behavior

It should hide the dialog header
@mohamedelsayedhussein mohamedelsayedhussein added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 29, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 30, 2024
@mertsincan mertsincan added this to the 19.0.3 milestone Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Review
Milestone
19.0.3
Development

No branches or pull requests
2 participants
@mertsincan @mohamedelsayedhussein