Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: Material Theme increment/decrement buttons misaligned; missing semi-colon #17256

Open
4 tasks
honboubao opened this issue Dec 30, 2024 · 0 comments · May be fixed by #17257
Open
4 tasks

InputNumber: Material Theme increment/decrement buttons misaligned; missing semi-colon #17256

honboubao opened this issue Dec 30, 2024 · 0 comments · May be fixed by #17257
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@honboubao
Copy link
Contributor

honboubao commented Dec 30, 2024 •
edited
Loading

Describe the bug

With the Material Theme applied, the buttons to increment and decrement the value in p-inputnumber are not vertically aligned in the center.

CSS properties top and right have no effect because of missing semi-colon:

primeng/packages/themes/src/presets/material/inputnumber/index.ts

Line 42 in df74566

top: 2px

Pull Request Link

#17257

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/stackblitz-starters-ugew1rpr

Environment

Windows 10
Firefox 128.3.1esr

Angular version

19.0.5

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Apply Material theme
  2. add p-inputnumber with showButtons

Expected behavior

CSS top and right are applied as intended
@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 30, 2024
honboubao pushed a commit to honboubao/primeng that referenced this issue Dec 30, 2024
fix: Fixes primefaces#17256 inputnumber Material theme CSS missing se…
7fd99d1 
…mi-colon
@honboubao honboubao linked a pull request Dec 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fixes #17256 inputnumber Material theme CSS missing semi-colon honboubao/primeng
1 participant
@honboubao