Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-menu Nested MenuItem visible flag doesn't work on PrimeNG v19 #17262

Open
1 of 4 tasks
shawnweeks opened this issue Dec 30, 2024 · 2 comments
Open
1 of 4 tasks

p-menu Nested MenuItem visible flag doesn't work on PrimeNG v19 #17262

shawnweeks opened this issue Dec 30, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@shawnweeks
Copy link

Describe the bug

The p-menu component's MenuItem visible flag doesn't work for nested items in PrimeNG 19+. This appears to be due to a missing p-hidden CSS style that was included in previous versions. This is a followup to #17204 which resolved the issue for non nested menu items.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-nr4xpl6r-qntkcyjt

Environment

Default StickBlitz environment based on PrimeNG Issue Template

Angular version

19.0.5

PrimeNG version

v19

Node version

18.20.3

Browser(s)

Firefox Latest, Chrome Latest, Safari Latest

Steps to reproduce the behavior

  1. Open Stackblitz link.
  2. Wait for project to start.
  3. Click green button
  4. Notice Search-Hidden isn't hidden despite visible flag being set to false

Expected behavior

Search-Hidden menu item should be hidden

@shawnweeks shawnweeks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 30, 2024
@junyou1998
Copy link

same

@Tsai-Ching
Copy link

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants