Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber Increment/Decrement Disabled Style Bug #17353

Open
2 of 4 tasks
Joebeurg opened this issue Jan 10, 2025 · 0 comments
Open
2 of 4 tasks

InputNumber Increment/Decrement Disabled Style Bug #17353

Joebeurg opened this issue Jan 10, 2025 · 0 comments
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@Joebeurg
Copy link

Joebeurg commented Jan 10, 2025

Describe the bug

After the update to PrimeNg v18, the Input Number component no longer shows the increment/decrement buttons as disabled, only the input.

The buttons can still be focused and clickable, even though functionality is not triggered when clicked, but they are misleading and should be styled as before with lower opacity (0.6), pointer-events: none, and cursor: default.

Primeng v17:
https://stackblitz.com/edit/dgmwhhmz?file=src%2Fapp%2Finput-number-buttons-demo.html
image

PrimeNg v18:
https://stackblitz.com/edit/qfymj4qd?file=src%2Fapp%2Finput-number-buttons-demo.html
image

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/qfymj4qd?file=src%2Fapp%2Finput-number-buttons-demo.html

Environment

Ubuntu 24.10

Angular version

18.2.10

PrimeNG version

v18 (LTS Only)

Node version

20.18.1

Browser(s)

Edge and Chrome 131

Steps to reproduce the behavior

Set [disabled]="true" and [showButtons]="true" on the input number component, both modes (stacked, or horizontal)

Expected behavior

Increment/decrement buttons should be disabled when the input number component has the disabled attribute set to true.

@Joebeurg Joebeurg added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 10, 2025
@mertsincan mertsincan added Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Theme
Development

No branches or pull requests

2 participants