Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiredMenu: Keyboard navigation breaks when using templates #7312

Closed
mozzerbob opened this issue Oct 6, 2024 · 2 comments
Closed

TiredMenu: Keyboard navigation breaks when using templates #7312

mozzerbob opened this issue Oct 6, 2024 · 2 comments
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted

Comments

@mozzerbob
Copy link

Describe the bug

Without a template you are able to use the keyboard to navigate to and trigger the command on a menu item by pressing enter. When using a template, keyboard selection works as expected to select an item but hitting enter does not trigger the command anymore.

Reproducer

https://stackblitz.com/edit/l7ugbc?file=src%2FApp.jsx

System Information

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    primereact: latest => 10.8.3 
    react: 18.3.1 => 18.3.1

Steps to reproduce the behavior

See the example, the 'New' option has been given a template, and the command no longer works when you use the keyboard.

Everything else in the Menu seems to work fine.

Expected behavior

I would expect for it to work the same regardless of if an item has a template or not.

@mozzerbob mozzerbob added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 6, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 15, 2024
@melloware
Copy link
Member

Closing in favor of this one which boils it down nicely to all MenuItem's not just menuBar: #7505

@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

This issue is a duplicate and has already been reported and possibly fixed. Please review other issues both open and closed for a similar issue to this one.

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted
Projects
None yet
Development

No branches or pull requests

2 participants