No ceillight for dining room/kitchen/living-room

[GCChen97]

Steps to Reproduce

Generate one indoor scene:

python -m infinigen_examples.generate_indoors --seed 0 --task coarse --output_folder outputs/indoors/coarse -g fast_solve.gin -p compose_indoors.terrain_enabled=False

What version of the code were you using?

Ver. 1.10.1

What are your FULL output logs?

50266977628_0_log (copy).err.txt

Additional context

I noticed that most of the log files contain the following messages related to dining room/kitchen/living-room

[21:42:55.183] [solve] [INFO] | No objects to be added for desc_full=('on_ceiling_2', 'dining-room_0/0'), skipping
[21:42:55.269] [solve] [INFO] | No objects to be added for desc_full=('on_ceiling_3', 'kitchen_0/0'), skipping
[21:42:55.356] [solve] [INFO] | No objects to be added for desc_full=('on_ceiling_4', 'living-room_0/0'), skipping

And the generated scenes would have no ceiling lights, which makes these rooms too dark. However, bathroom and bedroom have no such problem. As far as I know, the example constraint file has defined the constraints for every room on the ceil lights:

    ...
    ceillights = lights[lamp.CeilingLightFactory]

    constraints["ceiling_lights"] = rooms.all(
        lambda r: (ceillights.related_to(r, cu.hanging).count().in_range(1, 4)) # at least one light for each room
    )
    ...

If I didn't misunderstand the code, this constraint was trying to make sure at least one light in each room. But it didn't work.

Before I've also tried to make a familiar constraint for adding some primitives in every room and noticed that it only worked for bathrooms and bedrooms. Ultimately, I had to manually add the constraints for each room instead of using rooms.all:

    ...
    constraints[<ROOM_TYPE>] = <ROOM_TYPE>.all(
        ...
        * primitives.related_to(r).count().in_range(1, 5)
    ...

I've tried adding ceillight number constraints to each room separately and it did work.

[araistrick]

Thanks for the report and sorry for slow reply, I will look into this now as its likely a bug in my solver code.