Failure to simplify units in very simple case

[mattfbacon]

> s = 34 gallons to L
128.704000656 L
> k = 10.7 kwh / L
10.7 kWh / L
> s * k
1377.1328070192 L kWh / L

[printfn]

Thanks for the report. The reason this fails to simplify is that because you're first converting s explicitly to a specific unit, fend tracks that s should not be auto-simplified further. You can see this by running @debug s, which shows not simplifiable as one of the flags. This flag is set whenever you use to to explicitly convert to a specific unit.

Multiplying s with another value carries over this not simplifiable flag, causing fend to not simplify s * k.

If you instead calculate e.g.:

> s = 34 gallons
34 gallons
> k = 10.7 kwh / L
10.7 kWh / L
> s * k
1377.1328070192 kWh

fend manages to correctly simplify the units.

I'm not sure how to best fix this. One option would be to automatically drop the flag when the units change due to multiplication or such, but I'll need to carefully test to make sure this doesn't cause unintentional regressions.

Also note that flags are only carried over from the value on the left-hand side, so k * s does simplify correctly.

[mattfbacon]

I think it would be appropriate to simplify it anyway if the unit is exactly the same, i.e., not not just the same quantity but also the same actual unit. Also, what is the intended value of this "not simplifiable" flag and is it possible to disable with config?

[printfn]

The flag is important because it prevents fend from auto-simplifying any calculations that are explicitly converted to a specific unit with to.

For example:

> 4 watts * 3 seconds
12 joules
> 4 watts * 3 seconds to N m
12 N m

It makes it possible to use units like Newton-metres without having them be auto-converted to joules.

But anyway, reenabling auto-conversions after multiplying values (or doing other maths operations) does make sense I think, to make sure that calculations like (34 gallons to L) * (10.7 kwh / L) work properly.