-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for MultiSubnetFailover when using a High Availability Group #337
Comments
An example of implementation is here:
|
Thanks @dariusj18 . That seems relatively simple so maybe the maintainers could implement this pretty quickly in their rust code. I tried looking at the connection code and I'm definitely not qualified to try a PR in Rust. |
I'd give it stab, but I am kinda worried that PRs won't be merged in. There hasn't been much activity and a few people that have commented say things like "I'm not the owner of this crate anymore" So I don't know if anyone is really maintaining it. |
Upon further further evaluation, the TcpStream connection is created in a few places tiberius/src/sql_browser/async_std.rs Line 16 in e74b556
tiberius/src/sql_browser/tokio.rs Line 18 in e74b556
tiberius/src/sql_browser/smol.rs Line 17 in e74b556
it seems that these exist for different library compatibilities. |
So do you think we need to post an issue on prisma-engines as well or is this still the right place? |
This is the right place. |
I created a simple example PR #357 with changes I assume would be needed. This is the first time I have touched rust, so I am not sure if it is correct. Also, if it is correct, the same changes would be needed to be made to tokio and smol implementations. |
This is a really important property, and this is the only crate where I found a mention of MultiSubnetFailover. Unfortunately, I get the impression that the project is no longer being developed. 😢 |
Currently Prisma doesn't support the MultiSubnetFailover option of SQL Server. See prisma/prisma#9187. I think this would require support at the driver level so I'm adding an issue here.
Other info: https://learn.microsoft.com/en-us/dotnet/framework/data/adonet/sql/sqlclient-support-for-high-availability-disaster-recovery
The text was updated successfully, but these errors were encountered: