Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height attribute in PrismicNextImage is not always an integer #96

Open
john-mantas opened this issue Sep 1, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@john-mantas
Copy link

When using <PrismicNextImage /> with the width prop defined but without specifying a height, the resolved height may result in a floating-point value, which doesn't follow the html spec and triggers errors when you run it throught https://validator.w3.org/nu/.

height

Versions

  • @prismicio/next: v1.6.0
  • next: v14.2.7
  • node: v18.19.1

Reproduction

Upload an image with 128x37 px size in Prismic and use it with <PrismicNextImage field={image} width={110} />.

Steps to reproduce

Check the img element in dev tools or validate the page to https://validator.w3.org/nu/.

What is expected?

Resolved height should always be a non-negative integer.

What is actually happening?

The height isn't always an integer, depending on the width/ar it can be a floating-point number.

@john-mantas john-mantas added the bug Something isn't working label Sep 1, 2024
Copy link

github-actions bot commented Sep 1, 2024

This issue has been labeled as a bug since it was created using the 🚨 Bug Report Template.

Hi there, thank you so much for the report!

Following our Maintenance Process, we will review your bug report and get back to you next Wednesday. To ensure a smooth review of your issue and avoid unnecessary delays, please make sure your issue includes the following:

  • Information about your environment and packages you use (Node.js version, package names and their versions, etc.)
    Feel free to attach a copy of your package.json file.
  • Any troubleshooting steps you already went through
  • A minimal reproduction of the issue, and/or instructions on how to reproduce it

If you have identified the cause of the bug described in your report and know how to fix it, you're more than welcome to open a pull request address it. Check out our quick start guide for a simple contribution process.

If you think your issue is a question (not a bug) and would like quicker support, please close this issue and forward it to an appropriate section on our community forum: https://community.prismic.io

- The Prismic Open-Source Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant