Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[Testool] Panic_attempt to subtract with overflow #1770

Open
ChihChengLiang opened this issue Feb 16, 2024 · 0 comments
Open

[Testool] Panic_attempt to subtract with overflow #1770

ChihChengLiang opened this issue Feb 16, 2024 · 0 comments
Labels
T-bug Type: bug

Comments

@ChihChengLiang
Copy link
Collaborator

What command(s) is the bug in?

cd testool; cargo run -r -- --suite nightly --inspect stackOverflowM1PUSH_d10_g0_v0

Describe the bug

thread 'main' panicked at 'attempt to subtract with overflow', zkevm-circuits/src/instance.rs:266:24

The root cause is the circuit takes a transition whose calldata exceeds the max calldata size.

let calldata_count = all_calldata.len();
// concat call data with call data padding
let calldata_chain = iter::empty()
.chain(all_calldata)
.chain((0..max_calldata - calldata_count).map(|_| 0u8));

We should raise errors and capture them properly, so that the report shows it as "Fail" instead of "Panic".

get_pi_bytes

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

No response

@ChihChengLiang ChihChengLiang added the T-bug Type: bug label Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

1 participant