Improved disclosure permission close dialog #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it was looking up the confirm button by text, but the text has changed, so it couldn't find it
jappe999
reviewed
Feb 7, 2025
| @@ -212,10 +212,10 @@ | |||
| "decline_signature": "Don't sign" | |||
| }, | |||
| "confirm_close_dialog": { | |||
| "title": "Cancel data sharing", | |||
| "title": "Are you sure?", | |||
There was a problem hiding this comment.
The buttons were a bit misleading but I think the original title was more descriptive about the action the user is about to take.
There was a problem hiding this comment.
Good point. I was kind of debating this change, as "Cancel sharing data" is not really a question that can be answered with "yes" or "no". But it's true that "Are you sure?" is not really descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some button texts and made the "actually stop" button the primary action.
Fixes #315