Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polling interval #201

Open
lukasmatusiewicz opened this issue Dec 11, 2024 · 2 comments
Open

Fix polling interval #201

lukasmatusiewicz opened this issue Dec 11, 2024 · 2 comments

Comments

@lukasmatusiewicz
Copy link
Contributor

lukasmatusiewicz commented Dec 11, 2024

  1. Poll in browser by reload doesn't keep polling interval set in config.

  2. Does we need this option in config? Or maybe it is enough to hard-set "4, 3, 2" as it is in other plugins?

@nilsbehlen
Copy link
Member

i dont understand what the problem is

@lukasmatusiewicz
Copy link
Contributor Author

lukasmatusiewicz commented Dec 16, 2024

@nilsbehlen

i dont understand what the problem is

  1. It doesn't work for some reason. I have to fix it.
  2. I had an idea that this could be a good moment to hard-code it to 4,3,2 intervals, as it's done in some other of our plugins, to reduce the config a little bit (it becomes really large). And this particular option is unnecessary for me because the default 4,3,2 works just perfectly. I mean, why should anybody need to change it? In other plugins it isn't configurable and it's fine. I write it only to discuss. If it should stay, I can just fix it and let it be as it was - no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants