-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the external.invoke by @pierredavidbelanger #47
Conversation
@pierredavidbelanger Hello. First of all I'm sorry for all the mess. In the original PR I said something about hardcoding an OS and that was wrong of me — seems I confused some of your changes with parts of another PRs changes by another person. I wanna try building your latest change, but before I do that, can you confirm that the latest build in the releases section still has an issue to fix? Give me a signoff and I'll merge this PR here to trigger a build for testing whether your change fixes it for all platforms. |
Oh! Nice of you of resurecting this tool. Ill help. As soon as I have a couple minute in front of the PC ill try your latest release. Then I will clone your fork instead of the upstream version so I can tryt to help, it will not be much though, I have no clue about what i am doing when working with Rust yet. |
Your fix branch is already part of this here PR I opened myself, so you don't really have to re-fork necessarily. I realized I accidentally made it package extra crud from the compilation directory along with the executable with the release. Afraid of touching the build script right now, during this PR. Hopefully that's not a problem. You can discard everything aside from the executable. Take your time and merry holidays. 😄 |
Ok, I can confirm , your latest build for linux throws a lot of javascript error, and also has no widgets in the UI I may be worth to note, I am starting the app with custom gamelog and soundpack options (both paths exists):
|
That's how it was on the original repo, I have to assume. |
Gosh. Something went wrong with the workflow run. |
I think the permissions are restricted for fork PRs. |
Couldn't really re-run the workflow after changing its permissions on this already merged PR. |
Seems to work fine on Windows here. |
By the way… 😅
Me neither! I'm not actually getting into developing this project but just want to maintain it in order to allow community contributions — like yours. |
Had my friend @Elerphore test on |
Fixes #19