Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light filters have incorrect guides #698

Open
erjiang opened this issue Oct 23, 2023 · 1 comment
Open

Light filters have incorrect guides #698

erjiang opened this issue Oct 23, 2023 · 1 comment

Comments

@erjiang
Copy link

erjiang commented Oct 23, 2023

Screenshot shows a PxrBarnLightFilter attached to a PxrDistantLight:

Selection_001

However, the guidelines extending from the PxrBarnLightFilter appear to be calculated incorrectly, and they are affected by rotation of the PxrDistantLight around its normal axis (which should have no effect on the light). The rendered results are not affected by this issue.

light-filter-bug.blend.zip
@prman-pixar
Copy link
Owner

Thanks for the report. I can reproduce the issue, so will look into it.

prman-pixar pushed a commit that referenced this issue Apr 8, 2024
Workaround fix for GitHub #698
8349a13 
For now, don't draw the projection if the barn light filter is in physical mode.
It's also not clear to me how the projection should be drawn if the same light filter is attached to two or more lights.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erjiang @prman-pixar