Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets option from the old stylemark is missing in the new stylemark #230

Closed
mbehzad opened this issue Apr 15, 2024 · 1 comment
Closed

Comments

@mbehzad
Copy link
Contributor

mbehzad commented Apr 15, 2024

lsgAssetsSrc was removed with the note: "... pv-scripts users can just use the resources folder". The issue with that is that the resource directory is meant to be part of the clientLibraries and will be deployed to the production. And shouldn't contain styleguide specific content.
PR #226 will add the stylemark's assests option back, which can be used for any icons, css, etc that is needed only for the styleguide.

@friewerts
Copy link
Member

see comment in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants