Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak lensing updates #1074

Merged
merged 27 commits into from
Oct 2, 2024
Merged

Weak lensing updates #1074

merged 27 commits into from
Oct 2, 2024

Conversation

timwhite0
Copy link
Collaborator

Most recent results on DC2:

BLISS:
shear 1 test MSE = 3.2e-05
shear 2 test MSE = 4.7e-05
convergence test MSE = 3.5e-05

Predicting zero in every tile:
shear 1 test MSE = 6.8e-05
shear 2 test MSE = 6.9e-05
convergence test MSE = 1.4e-04

See notebooks/dc2/evaluate_encoder.ipynb in our case study for corresponding shear/convergence maps and scatterplots. In our next PR, we'll provide results for an estimator based on averaging ellipticities of neighboring galaxies (already implemented in utils/weighted_avg_ellip.py, just needs to be tuned).

A couple more updates for both DC2 and our simulator:

  • Slightly more complicated prior than our last PR. We still generate images with constant shear and convergence, but now the values of shear/convergence are allowed to differ from image to image.
  • We now plot a few shear and convergence maps during training, instead of just one. We also plot a scatterplot of our estimates vs. the ground truth for shear1, shear2, and convergence.
  • Some housekeeping things: separate configs for DC2 and synthetic images, new weak lensing README.

timwhite0 and others added 27 commits September 18, 2024 22:15
@timwhite0 timwhite0 requested a review from jeff-regier October 2, 2024 02:45
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (1868ae0) to head (ab273b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   76.14%   76.15%   +0.01%     
==========================================
  Files          22       22              
  Lines        3089     3091       +2     
==========================================
+ Hits         2352     2354       +2     
  Misses        737      737              
Flag Coverage Δ
unittests 76.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeff-regier jeff-regier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jeff-regier jeff-regier merged commit 1baf4d4 into master Oct 2, 2024
3 checks passed
@jeff-regier jeff-regier deleted the tw/weak_lensing branch October 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants