add data augmentation and dc2 psf/deconv #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
+ Coverage 95.78% 95.88% +0.09%
==========================================
Files 25 26 +1
Lines 3111 3209 +98
==========================================
+ Hits 2980 3077 +97
- Misses 131 132 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeff-regier
requested changes
Aug 24, 2023
jeff-regier
reviewed
Aug 24, 2023
jeff-regier
reviewed
Aug 24, 2023
jeff-regier
reviewed
Aug 24, 2023
jeff-regier
reviewed
Aug 24, 2023
XinyueLi1012
force-pushed
the
dc2-coadded
branch
from
a078d4b to
b258fb6
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jeff-regier
reviewed
Aug 31, 2023
jeff-regier
reviewed
Aug 31, 2023
jeff-regier
reviewed
Aug 31, 2023
jeff-regier
reviewed
Aug 31, 2023
bliss/data_augmentation.py
Outdated
|
|
||
| num_channel = image.size(2) | ||
| aug_images = [] | ||
| for i in range(num_channel): |
There was a problem hiding this comment.
Same here, it'd be nice not to loop over the channels. We should be able to pad and slice all the channels at once.
jeff-regier
reviewed
Aug 31, 2023
jeff-regier
requested changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will resolve data augmentation #904 and demonstrate that BLISS outperforms the LSST pipeline at cataloging DC2 #898