diff --git a/skore/src/skore/sklearn/find_ml_task.py b/skore/src/skore/sklearn/find_ml_task.py index 7ba71f528..994196494 100644 --- a/skore/src/skore/sklearn/find_ml_task.py +++ b/skore/src/skore/sklearn/find_ml_task.py @@ -72,7 +72,7 @@ def _find_ml_task(y, estimator=None) -> MLTask: return "multiclass-classification" else: # fallback on the target if y is None: - return "unsupported" + return "unknown" target_type = type_of_target(y) if target_type == "binary": @@ -84,8 +84,8 @@ def _find_ml_task(y, estimator=None) -> MLTask: if _is_sequential(y) and 0 in y: return "multiclass-classification" return "regression" - return "unsupported" - return "unsupported" + return "unknown" + return "unknown" else: if y is None: # NOTE: The task might not be clustering @@ -104,4 +104,4 @@ def _find_ml_task(y, estimator=None) -> MLTask: if _is_sequential(y) and 0 in y: return "multiclass-classification" return "regression" - return "unsupported" + return "unknown" diff --git a/skore/src/skore/sklearn/types.py b/skore/src/skore/sklearn/types.py index f6b4184cb..3ac85af88 100644 --- a/skore/src/skore/sklearn/types.py +++ b/skore/src/skore/sklearn/types.py @@ -7,5 +7,5 @@ "multiclass-classification", "regression", "clustering", - "unsupported", + "unknown", ] diff --git a/skore/tests/unit/sklearn/test_utils.py b/skore/tests/unit/sklearn/test_utils.py index 680b748d3..08675c0c5 100644 --- a/skore/tests/unit/sklearn/test_utils.py +++ b/skore/tests/unit/sklearn/test_utils.py @@ -28,7 +28,7 @@ ( *make_multilabel_classification(random_state=42), MultiOutputClassifier(LogisticRegression()), - "unsupported", + "unknown", ), ], ) @@ -53,7 +53,7 @@ def test_find_ml_task_with_estimator(X, y, estimator, expected_task, should_fit) ), (make_regression(n_samples=100, random_state=42)[1], "regression"), (None, "clustering"), - (make_multilabel_classification(random_state=42)[1], "unsupported"), + (make_multilabel_classification(random_state=42)[1], "unknown"), (numpy.array([1, 5, 9]), "regression"), (numpy.array([0, 1, 2]), "multiclass-classification"), (numpy.array([1, 2, 3]), "regression"), @@ -68,4 +68,4 @@ def test_find_ml_task_unfitted_estimator(): from sklearn.dummy import DummyClassifier estimator = DummyClassifier() - assert _find_ml_task(None, estimator) == "unsupported" + assert _find_ml_task(None, estimator) == "unknown" diff --git a/skore/tests/unit/utils/test_accessors.py b/skore/tests/unit/utils/test_accessors.py index 7e7a8953b..7dd908f50 100644 --- a/skore/tests/unit/utils/test_accessors.py +++ b/skore/tests/unit/utils/test_accessors.py @@ -30,7 +30,7 @@ def func(self): def test_check_supported_ml_task(): - """Test that ML task validation accepts supported tasks and rejects unsupported + """Test that ML task validation accepts supported tasks and rejects unknown ones. """