-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance skore.cross_validate
#544
Comments
Another short enhancement:
|
To be honest, this issue is getting a bit big. Can we create individual issues? |
@augustebaum I created 3 smaller issues. |
Created to two issues of this larger issue that I would consider a small epic |
Now that this has been divided up I'll go ahead and close this |
skore.cross_validate`
First PR of this new feature: #443, cc @MarieS-WiMLDS and @augustebaum. Issue: #383.
Some issues arose in #443 (comment), that have been separated to this new GitHub issue. The issue is written again here:
EDIT : after a discussion with @augustebaum, maybe we can keep both, but in all cases, we should say somewhere what is actually behind
test_score
.For the fit time:
Note:
neg_mean_squared_error
is actually meant to be negative and behave like a score (the higher, the better). But still, naming "results" is better I believe.Maybe we can say something like "Cross-validation results" and the y-label is "Results", so that it can be appropriate for scores, errors, and times
EDIT by @augustebaum : Done
plotly
before the first release, because DS are much more familiar withplotly
than withaltair
. See dropdowns in plotly.EDIT: Tis is the new display that does not have a dropdown menu but does the same & it can enable us to compare the training and testing times together which is very useful ; if we had the train score then we can also compare the train and test scores together
Enregistrement.de.l.ecran.2024-10-17.a.17.46.57.mov
The text was updated successfully, but these errors were encountered: