Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FotMob] Multiple Invalid Stat Types for FotMob #528

Open
6abd opened this issue Apr 1, 2024 · 6 comments
Open

[FotMob] Multiple Invalid Stat Types for FotMob #528

6abd opened this issue Apr 1, 2024 · 6 comments
Labels
bug Something isn't working FotMob Issue or pull request related to the FotMob scraper

Comments

@6abd
Copy link

6abd commented Apr 1, 2024

When trying to call read_team_match_stats(), the stat types given by the docs cause an "Invalid stat type" error for multiple categories. The "Top stats" category seems to be one of the only working ones.

@6abd
Copy link
Author

6abd commented Apr 1, 2024

I also just discovered that stats in the working "Top stats" category show the opponents' stats for each metric.

@marcjbaron
Copy link
Contributor

What seasons and leagues are causing the issues?

@6abd
Copy link
Author

6abd commented Apr 3, 2024

What seasons and leagues are causing the issues?

I've only done the 2015-16 Barcelona season because that's what I'm using for a project, but it is probably a site-wide thing due to changes. FBref also could have an added playing-time stat and I think some outdated requests because some of the stat categories don't work on that site too.

@marcjbaron
Copy link
Contributor

I've only done the 2015-16 Barcelona season because that's what I'm using for a project, but it is probably a site-wide thing due to changes.

Yes, it looks like there are limited stats available for seasons prior to 2016-2017, so the available stats are all in the "Top stats" category.

For the second issue, if you set opponent_stats=False, it will give you the requested team's stats. When it is set to True (the default setting), it should give both team's stats, but it only returns the opponent's stats, so that's an issue that may be worth looking into.

@probberechts probberechts added FotMob Issue or pull request related to the FotMob scraper bug Something isn't working labels Apr 4, 2024
@6abd
Copy link
Author

6abd commented Apr 4, 2024

I've only done the 2015-16 Barcelona season because that's what I'm using for a project, but it is probably a site-wide thing due to changes.

Yes, it looks like there are limited stats available for seasons prior to 2016-2017, so the available stats are all in the "Top stats" category.

For the second issue, if you set opponent_stats=False, it will give you the requested team's stats. When it is set to True (the default setting), it should give both team's stats, but it only returns the opponent's stats, so that's an issue that may be worth looking into.

Ok, thank you.

@fofota
Copy link

fofota commented Jun 18, 2024

Hey, just to add to this.

When I run Bolton Wanderers in ENG League One for the 2023/24 season using this code

match_stats = fotmob.read_team_match_stats(opponent_stats=True, team='Bolton Wanderers', stat_type='Expected goals (xG)')

I get an error - and closer inspection this appears to be that some of this club's games were abandoned in the year.

Specifically when I run this code

schedule = fotmob.read_schedule()
bolton_games = schedule[(schedule['home_team'] == 'Bolton Wanderers') | (schedule['away_team'] == 'Bolton Wanderers')]
bolton_games

Then for some games status = Ab (as opposed to FT, which is what most games say) and this leads to an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FotMob Issue or pull request related to the FotMob scraper
Projects
None yet
Development

No branches or pull requests

4 participants