Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-full-screen Container View Controllers #59

Open
problame opened this issue Apr 26, 2015 · 0 comments
Open

Non-full-screen Container View Controllers #59

problame opened this issue Apr 26, 2015 · 0 comments
Labels

Comments

@problame
Copy link
Owner

As documented in the discussion in #57 and #56, CSNotificationView is displayed with the status bar offset in a container view controller.

The key point is: CSNotificationView cannot always rely on the layout guides provided by the view controllers it is presented in. (Details in the comments on #57):

Hence, it has a method that calculates the .length property of what would normally be the topLayoutGuide, taking into account

  • the status bar height
  • if the parent UINavgiationController has its navigation bar visible or not

This behavior breaks in Container View Controllers that are not full-screen and also in modal Form-Style View Controllers on iPad.

The main author (me) does not have the time to fix this bug properly. I would appreciate pull requests that if possible maintain backwards-compatibility.

@problame problame added the bug label Apr 26, 2015
tobihagemann added a commit to tobihagemann/CSNotificationView that referenced this issue May 20, 2015
…re, but derived from topLayoutGuide.length
tobihagemann added a commit to tobihagemann/CSNotificationView that referenced this issue May 20, 2015
…re, but derived from topLayoutGuide.length
tobihagemann added a commit to tobihagemann/CSNotificationView that referenced this issue May 20, 2015
…re, but derived from topLayoutGuide.length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant