-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast GPIO button clicks go undetected #713
Comments
Possibly we should lower |
Please test the build from #714 - does it improve/solve the issue? |
If the issue is detecting short presses in the first place, rather than repeated presses, then it is probably BUTTONS_UPDATE_NUM_TICKS that needs decreasing. This would however mean that more time is spent checking buttons rather than processing audio, so we'd need to check performance on lower-end devices too to ensure audio is still ok. DEBOUNCE_TIME I'd expect would affect how quickly a second press of the button is recognised, e.g. in a double click. I don't recall how we came up with those numbers - I expect it was an "initial finger in the air" guess and then see how it works :) Kevin |
(copied from my response in #714) Wow, Thanks! This seems to be working great. Even the fastest, lightest taps get registered. Actually I just tested again and the back button is good, it was the performance up and down that took a moment to change between taps, but i guess a 1/3 second is to be expected because it is loading a whole performance. menu navigation is super fast. This build definitely solves my issue |
Im closing this. Everything is working fine now w/ the latest release |
Ive recently completed a minidexed build that uses mechanical keyboard switches for GPIO buttons and Im finding that with these switches which allow for faster click action (vs the standard tiny pcb tactile switch) , many times the quick taps go undetected and it requires sort of a longer deliberate press to be recognized. I assume that this is due to a switch debounce delay in software. Is there any way to customize this? ... or can it be added as a custom setting, like the double click and longpress timeouts?
The text was updated successfully, but these errors were encountered: