Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do only one posting that contains all uploaded artifacts #23

Open
probonopd opened this issue Nov 19, 2017 · 5 comments
Open

Do only one posting that contains all uploaded artifacts #23

probonopd opened this issue Nov 19, 2017 · 5 comments

Comments

@probonopd
Copy link
Owner

@dirkhh this is what currently happens when there are many build artifacts:

spam

Especially with my avatar next to it, I am sure this makes me perceived a "spammer" in no time ;-)

There should be only one posting that contains all uploaded artifacts, rather than one per artifact.
Do you think this is possible?

@dirkhh
Copy link
Contributor

dirkhh commented Nov 19, 2017

The posts should be all from the repo owner - so you'll only be a spammer on your own repo.
But I agree that this is kinda annoying. Let me look at this to see if we can combine them all into one comment which would be much nicer, I agree.
I'm not a great shell programmer, but this shouldn't be too hard...

@probonopd
Copy link
Owner Author

Keep in mind, though, that there may be more than one build running in parallel (e.g., different architectures). Can we still have just one posting?

@dirkhh
Copy link
Contributor

dirkhh commented Nov 19, 2017

My current approach is to first deal with multi artifacts in one call to upload.sh each creating a new comment. I have the code for that, am testing right now.
Once that works, I'll look into multi-arch as well.

@probonopd
Copy link
Owner Author

Something still doesn't look quite right:
AppImage/AppImageKit#565

For the meantime, is there a way to disable this?

@dirkhh
Copy link
Contributor

dirkhh commented Dec 4, 2017

I think we need to revert the commit that posts a review comment for the build artifacts.
It works fine in some scenarios, but in general... it isn't useful. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants