Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload releases unless on primary branch #30

Open
TheAssassin opened this issue Feb 8, 2018 · 2 comments
Open

Don't upload releases unless on primary branch #30

TheAssassin opened this issue Feb 8, 2018 · 2 comments

Comments

@TheAssassin
Copy link
Contributor

Note: the term master branch is avoided on purpose. Many projects use another branch as primary branch, e.g., AppImageKit uses appimagetool/master, AppImageUpdate uses rewrite at the moment.

In many projects, there's development ongoing in branches outside the primary branch. Not everyone is happy with n forks for n developers, and for e.g., your own projects, GitHub creates branches in the same repository during many operations like file editing.

In such scenarios, uploadtool should not upload binaries to GitHub releases when Travis builds those branches. Instead, it should follow the PR strategy, and upload the binaries to https://transfer.sh (or some other location, see #28).

My current workaround in many projects is a line in the .travis.yml:

https://github.com/AppImage/AppImageUpdate/blob/65b152ef3c5737aa7bea24ccd350556482a5656d/.travis.yml#L17

@TheAssassin
Copy link
Contributor Author

The GitHub API returns a default_branch: field in the repo API:
https://api.github.com/repos/AppImage/AppImageKit

@probonopd
Copy link
Owner

Yes, this would be a very useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants