Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build log to release description #33

Open
TheAssassin opened this issue Mar 29, 2018 · 3 comments
Open

Add build log to release description #33

TheAssassin opened this issue Mar 29, 2018 · 3 comments

Comments

@TheAssassin
Copy link
Contributor

I would appreciate if there was a link back to the Travis CI build log in the release description.

The functionality appears to be implemented, looking at the code, I am not sure why this isn't happening, though.

@probonopd could you please have a look why the URL isn't appended to the description?

@probonopd
Copy link
Owner

There is a check if [ ! -z "$UPLOADTOOL_BODY" ] ; then which I think evaluates to false, causing the log not to be appended. The variable and if clause was introduced in 494d5a5 - could it be that it needs to be if [ -z "$UPLOADTOOL_BODY" ] ; then?

@TheAssassin
Copy link
Contributor Author

@probonopd when using -z to check whether a variable has set, there must not be quotes, IIRC.
See also 494d5a5#diff-41c2c2edf223528193cd5163683cad3dR42.

A more straightforward (bash-only) syntax would be [ "$UPLOADTOOL_BODY" != "" ].

@TheAssassin
Copy link
Contributor Author

Also, I think you're right workflow wise, the ! negates the value of the check, which is not desired here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants