Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize and migrate to esm #127

Merged
merged 9 commits into from
Jul 21, 2024
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 20, 2024

how can we ensure that we release next version as a major?
should we target a next branch?

@Uzlopak Uzlopak changed the base branch from main to beta July 20, 2024 23:35
@Uzlopak Uzlopak mentioned this pull request Jul 20, 2024
@Uzlopak Uzlopak changed the title chore: migrate to esm chore: modernize and migrate to esm Jul 20, 2024
scripts/build.mjs Show resolved Hide resolved
scripts/build.mjs Show resolved Hide resolved
test/get-private-key.test.ts Outdated Show resolved Hide resolved
test/tsconfig.test.json Outdated Show resolved Hide resolved
test/smoke.test.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
scripts/build.mjs Outdated Show resolved Hide resolved
Copy link
Contributor

@wolfy1339 wolfy1339 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor consistency updates, otherwise it looks good

test/get-private-key.test.ts Outdated Show resolved Hide resolved
test/get-private-key.test.ts Outdated Show resolved Hide resolved
@Uzlopak Uzlopak merged commit d8ad4c1 into probot:beta Jul 21, 2024
5 checks passed
@Uzlopak Uzlopak deleted the migrate-to-esm branch July 21, 2024 00:29
Copy link

🎉 This issue has been resolved in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

AaronDewes pushed a commit that referenced this pull request Aug 3, 2024
BREAKING CHANGE: This package is now ESM only.

* feat: add support for PKCS8 keys (#129)

Co-authored-by: Samuel El-Borai <[email protected]>

* chore: modernize and migrate to esm (#127)

Co-authored-by: wolfy1339 <[email protected]>

---------

Co-authored-by: Samuel El-Borai <[email protected]>
Co-authored-by: wolfy1339 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants