From 1eecba4df7076b445dfe7eb4e2a80c57b314cd6e Mon Sep 17 00:00:00 2001 From: benjamin Date: Sun, 15 Oct 2023 16:29:15 -0400 Subject: [PATCH 1/4] typo and unused variable --- src/core/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/main.js b/src/core/main.js index 75c0d7d8cc..2e62bc661f 100644 --- a/src/core/main.js +++ b/src/core/main.js @@ -33,7 +33,7 @@ import * as constants from './constants'; * @return {p5} a p5 instance */ class p5 { - constructor(sketch, node, sync) { + constructor(sketch, node) { ////////////////////////////////////////////// // PUBLIC p5 PROPERTIES AND METHODS ////////////////////////////////////////////// @@ -776,7 +776,7 @@ for (const k in constants) { } // makes the `VERSION` constant available on the p5 object -// in instance mode, even if it hasn't been instatiated yet +// in instance mode, even if it hasn't been instantiated yet p5.VERSION = constants.VERSION; // functions that cause preload to wait From 93dfdb8224de23926fa0745c24ae546f4b245d04 Mon Sep 17 00:00:00 2001 From: Garima <110815240+Garima3110@users.noreply.github.com> Date: Tue, 17 Oct 2023 23:15:47 +0530 Subject: [PATCH 2/4] Update friendly_error_system.md --- contributor_docs/friendly_error_system.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributor_docs/friendly_error_system.md b/contributor_docs/friendly_error_system.md index 7cc3ecb2ed..0a1fe3c4d3 100644 --- a/contributor_docs/friendly_error_system.md +++ b/contributor_docs/friendly_error_system.md @@ -129,7 +129,7 @@ You can find the translation files used by the `translator()` inside: These functions are mainly responsible for catching errors and generating FES messages: * [`_friendlyFileLoadError()`] catches file loading errors. * [`_validateParameters()`] checks a p5.js function’s input parameters based on inline documents. -* [`_fesErrorMontitor()`] handles global errors. +* [`_fesErrorMonitor()`] handles global errors. For full reference, please see our [Dev Notes]. @@ -165,4 +165,4 @@ function setup() { The single minified file of p5 (i.e., p5.min.js) automatically omits the FES. -[disable the FES for performance]: https://github.com/processing/p5.js/wiki/Optimizing-p5.js-Code-for-Performance#disable-the-friendly-error-system-fes \ No newline at end of file +[disable the FES for performance]: https://github.com/processing/p5.js/wiki/Optimizing-p5.js-Code-for-Performance#disable-the-friendly-error-system-fes From 911f7816e6870d1152146808d01ebbe2ec26497e Mon Sep 17 00:00:00 2001 From: limzykenneth Date: Sun, 17 Sep 2023 21:33:20 +0100 Subject: [PATCH 3/4] Update version number on website on release --- .github/workflows/release.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ab18ad6e36..20e183e065 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,7 +25,10 @@ jobs: id: version-number run: | version=$(echo ${{ github.ref_name }} | cut -c 2-) - echo "::set-output name=version::$version" + echo "version=$version" >> $GITHUB_OUTPUT + - name: Get current date + id: date + run: echo "date=$(date +"%B %Oe, %Y")" >> $GITHUB_OUTPUT - name: Install dependencies run: npm ci env: @@ -81,6 +84,11 @@ jobs: value: ${{ steps.version-number.outputs.version }} commitChange: false updateFile: true + - name: Update version.json on website repo + uses: restackio/update-json-values-action@v1.0.0 + with: + file: website/dist/download/version.json + values: "{'version': '${{ steps.version-number.outputs.version }}', 'date': '${{ steps.date.outputs.date }}'}" - name: Update en.json on website repo run: | cd website From 65740709075ded18cc180ee2d372724faf16549b Mon Sep 17 00:00:00 2001 From: limzykenneth Date: Tue, 17 Oct 2023 20:56:00 +0100 Subject: [PATCH 4/4] Fix JSON formatting in CI --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 20e183e065..440f3045eb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -88,7 +88,7 @@ jobs: uses: restackio/update-json-values-action@v1.0.0 with: file: website/dist/download/version.json - values: "{'version': '${{ steps.version-number.outputs.version }}', 'date': '${{ steps.date.outputs.date }}'}" + values: '{"version": "${{ steps.version-number.outputs.version }}", "date": "${{ steps.date.outputs.date }}"}' - name: Update en.json on website repo run: | cd website