Skip to content

Commit 42628aa

Browse files
committed
Consolidate immediate mode into RendererGL + shape builder
1 parent 7d2df7d commit 42628aa

13 files changed

+1142
-1219
lines changed

src/webgl/3d_primitives.js

Lines changed: 109 additions & 99 deletions
Large diffs are not rendered by default.

src/webgl/GeometryBuilder.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,7 @@ class GeometryBuilder {
108108
* Adds geometry from the renderer's immediate mode into the builder's
109109
* combined geometry.
110110
*/
111-
addImmediate() {
112-
const geometry = this.renderer.immediateMode.geometry;
113-
const shapeMode = this.renderer.immediateMode.shapeMode;
111+
addImmediate(geometry, shapeMode) {
114112
const faces = [];
115113

116114
if (this.renderer.states.doFill) {
@@ -143,7 +141,7 @@ class GeometryBuilder {
143141
* combined geometry.
144142
*/
145143
addRetained(geometry) {
146-
this.addGeometry(geometry.model);
144+
this.addGeometry(geometry);
147145
}
148146

149147
/**

0 commit comments

Comments
 (0)