Date: Mon, 1 Jan 2024 06:29:15 +0900
Subject: [PATCH 17/23] add missing return type
---
src/core/p5.Graphics.js | 1 +
src/core/rendering.js | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/core/p5.Graphics.js b/src/core/p5.Graphics.js
index 2de8fe011b..9fa18e6090 100644
--- a/src/core/p5.Graphics.js
+++ b/src/core/p5.Graphics.js
@@ -204,6 +204,7 @@ p5.Graphics = class extends p5.Element {
* createFramebuffer function.
*
* @method createFramebuffer
+ * @return {p5.Framebuffer}
*/
createFramebuffer(options) {
return new p5.Framebuffer(this, options);
diff --git a/src/core/rendering.js b/src/core/rendering.js
index 6d5aa5804a..a2918217cc 100644
--- a/src/core/rendering.js
+++ b/src/core/rendering.js
@@ -322,6 +322,7 @@ p5.prototype.createGraphics = function(w, h, renderer, canvas) {
*
* @method createFramebuffer
* @param {Object} [options] An optional object with configuration
+ * @return {p5.Framebuffer}
*
* @example
*
From 33082af718c4c8007e04eca8427ca01195075e2c Mon Sep 17 00:00:00 2001
From: Rahul
Date: Mon, 1 Jan 2024 19:54:04 +0530
Subject: [PATCH 18/23] fixed the doubleClicked() in offline docs
---
docs/yuidoc-p5-theme/assets/js/render.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/yuidoc-p5-theme/assets/js/render.js b/docs/yuidoc-p5-theme/assets/js/render.js
index 8af9c9f8d5..aaac07bbb6 100644
--- a/docs/yuidoc-p5-theme/assets/js/render.js
+++ b/docs/yuidoc-p5-theme/assets/js/render.js
@@ -194,7 +194,7 @@ var renderCode = function(exampleName) {
var s = function( p ) {
var fxns = ['setup', 'draw', 'preload', 'mousePressed', 'mouseReleased',
- 'mouseMoved', 'mouseDragged', 'mouseClicked', 'mouseWheel',
+ 'mouseMoved', 'mouseDragged', 'mouseClicked','doubleClicked','mouseWheel',
'touchStarted', 'touchMoved', 'touchEnded',
'keyPressed', 'keyReleased', 'keyTyped'];
var _found = [];
From 00f516a2ab8891cb74c0c7f9c7f28da05de401c3 Mon Sep 17 00:00:00 2001
From: Rohit Paul <113459757+RohitPaul0007@users.noreply.github.com>
Date: Tue, 2 Jan 2024 16:09:35 +0530
Subject: [PATCH 19/23] Update contributor_guidelines.md
---
contributor_docs/contributor_guidelines.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contributor_docs/contributor_guidelines.md b/contributor_docs/contributor_guidelines.md
index a51f93103a..4f24c4ca27 100644
--- a/contributor_docs/contributor_guidelines.md
+++ b/contributor_docs/contributor_guidelines.md
@@ -208,7 +208,7 @@ Once the push is complete, you may see a link in the terminal that lets you open
### Pull request information
Before filing the pull request, you will need to fill out the pull request template. First of all the pull request title should briefly describe what the changes are, again avoid generic statements here.
-Next, in the template, there is this line `Resolves #[Add issue number here]` which you should replace `[Add issue number here]` with the issue number of the issue you are addressing/fixing [above](#all-about-issues) (eg. `Resolves #1234`). This will make sure the issue is automatically closed after this PR is merged. If you do not wish to automatically close the issue after this PR is merged (maybe because there are more changes coming in a separate PR), change `Resovles` to `Addresses`.
+Next, in the template, there is this line `Resolves #[Add issue number here]` which you should replace `[Add issue number here]` with the issue number of the issue you are addressing/fixing [above](#all-about-issues) (eg. `Resolves #1234`). This will make sure the issue is automatically closed after this PR is merged. If you do not wish to automatically close the issue after this PR is merged (maybe because there are more changes coming in a separate PR), change `Resolves` to `Addresses`.
For "Changes", you should give a clear description of the changes you have made in this PR. Include any implementation details and decisions you made here that are relevant to whoever will review this PR.
From 117464fd05f7aedd23419b8976944734969c0a4a Mon Sep 17 00:00:00 2001
From: Asuka Minato
Date: Wed, 3 Jan 2024 02:12:47 +0900
Subject: [PATCH 20/23] make parms optional
---
src/color/setting.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/color/setting.js b/src/color/setting.js
index 0dc35c6283..457e686dd0 100644
--- a/src/color/setting.js
+++ b/src/color/setting.js
@@ -441,10 +441,10 @@ p5.prototype.background = function(...args) {
*
*
*
- * @param {Number} r normalized red value.
- * @param {Number} g normalized green value.
- * @param {Number} b normalized blue value.
- * @param {Number} a normalized alpha value.
+ * @param {Number} [r] normalized red value.
+ * @param {Number} [g] normalized green value.
+ * @param {Number} [b] normalized blue value.
+ * @param {Number} [a] normalized alpha value.
*/
p5.prototype.clear = function(...args) {
const _r = args[0] || 0;
From 77574af390fd2fe4d30b29974dbf27ef8ed1fff1 Mon Sep 17 00:00:00 2001
From: Sudhanshu Tiwari
Date: Fri, 5 Jan 2024 10:12:55 +0530
Subject: [PATCH 21/23] fixed second example in the reference page for acos()
---
src/math/trigonometry.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/math/trigonometry.js b/src/math/trigonometry.js
index c22f0e4d80..8ee055030c 100644
--- a/src/math/trigonometry.js
+++ b/src/math/trigonometry.js
@@ -42,14 +42,14 @@ p5.prototype._angleMode = constants.RADIANS;
*
*
*
- * let a = PI;
+ * let a = PI-QUARTER_PI;
* let c = cos(a);
* let ac = acos(c);
* text(`${round(a, 3)}`, 35, 25);
* text(`${round(c, 3)}`, 35, 50);
* text(`${round(ac, 3)}`, 35, 75);
*
- * describe('The numbers 3.927, -0.707, and 2.356 written on separate rows.');
+ * describe('The numbers 2.356, -0.707, and 2.356 written on separate rows.');
*
*
*/
From 814509d73e8d28d858a83fc4f2390c8d3adb84f2 Mon Sep 17 00:00:00 2001
From: clemzio
Date: Sat, 6 Jan 2024 11:02:53 +0100
Subject: [PATCH 22/23] fix documentation typo in src/math/random.js
Fix minor documentation typo in `src/math/random.js`.
---
src/math/random.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/math/random.js b/src/math/random.js
index 4b9d519203..5a5ef7de60 100644
--- a/src/math/random.js
+++ b/src/math/random.js
@@ -108,7 +108,7 @@ p5.prototype.randomSeed = function(seed) {
* strokeWeight(5);
* point(x, y);
*
- * describe('A black dot appears in a random posiiton on a gray square.');
+ * describe('A black dot appears in a random position on a gray square.');
*
*
*
From dc814dca948234fb11591e03f54755510d82e5a9 Mon Sep 17 00:00:00 2001
From: Sudhanshu Tiwari
Date: Sat, 6 Jan 2024 22:23:03 +0530
Subject: [PATCH 23/23] made the requested changes in previous commit
---
src/math/trigonometry.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/math/trigonometry.js b/src/math/trigonometry.js
index 8ee055030c..303cdeba92 100644
--- a/src/math/trigonometry.js
+++ b/src/math/trigonometry.js
@@ -42,14 +42,14 @@ p5.prototype._angleMode = constants.RADIANS;
*
*
*
- * let a = PI-QUARTER_PI;
+ * let a = PI + QUARTER_PI;
* let c = cos(a);
* let ac = acos(c);
* text(`${round(a, 3)}`, 35, 25);
* text(`${round(c, 3)}`, 35, 50);
* text(`${round(ac, 3)}`, 35, 75);
*
- * describe('The numbers 2.356, -0.707, and 2.356 written on separate rows.');
+ * describe('The numbers 3.927, -0.707, and 2.356 written on separate rows.');
*
*
*/
