Fix usage of int() typecast in p5.strands #8254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
commented
Nov 10, 2025
| if (!gl.getShaderParameter(this._vertShader, gl.COMPILE_STATUS)) { | ||
| const glError = gl.getShaderInfoLog(this._vertShader); | ||
| if (typeof IS_MINIFIED !== 'undefined') { | ||
| if (typeof IS_MINIFIED !== 'undefined' || typeof p5 === 'undefined') { |
Contributor
Author
There was a problem hiding this comment.
I added this because I noticed this was crashing in tests when we hit this path due to p5 not being globally available. Ideally we do something where we patch this method onto the class in the addon function, but given the size of these functions, this is maybe a poor fit. Maybe there's a better way to integrate FES into other module files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
int(instanceID())used to not work, as it would create a generic numeric node without locking it in to being an int. Now, when a typecast call likeint()is called on an existing strands node, it gets treated like a function call rather than a constructor.int(...)as an equivalent tofloor(...)to create an instanced gridPR Checklist
npm run lintpasses