Inconsistent styling of alerts and error states

[daun]

The new admin theme allows customizing alert colors, but they aren't applied consistently. In general, I feel like the error states are a bit of a downgrade compared to the previous default theme and could need some more attention and harmonization. Having the interface look good even when things go wrong inspires a lot of trust in the users, so time spent optimizing this should be time well spent :)

Error states

There are the default alerts, which are styled according to the new theme. Then there is a notification bug component that seems untouched by the new variables, and notification ghosts that also define a new color. The error states of inputfields seem to be doing their own thing as well.

Alternative styles for error states

In general, I feel that a red border or background on the whole field might be the better approach. Isn't that how the previous theme worked anyway? Much clearer for the user.

[ryancramerdesign]

@daun I think it's because you've got the SystemNotifications module installed. I'd recommend uninstalling that, as it's not been updated in some time and probably will get removed from the core.

[daun]

@ryancramerdesign Yes, I have that installed and it's actually quite neat, too bad it'll be removed. But good to know!

Disregarding that part, I still find the current/previous way of marking invalid fields better. Adding a red border and background to the field makes things more obvious when/if things go wrong.