Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Rendering Functionality and Remove BaseHelpers Module #476

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Extract Rendering Functionality and Remove BaseHelpers Module #476

wants to merge 5 commits into from

Conversation

lessthanjacob
Copy link
Contributor

@lessthanjacob lessthanjacob commented Oct 14, 2024 •
edited
Loading

Resolves #432

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

Changelog

  • Extract rendering logic into Rendering module
  • Remove BaseHelpers module
  • Reformat Base class with class << self syntax
  • Rename public prepare_object to hashify to better match expectations.
  • Introduce new exceptions for meta/root errors

@lessthanjacob lessthanjacob self-assigned this Oct 14, 2024
@lessthanjacob lessthanjacob marked this pull request as ready for review October 29, 2024 13:48
@lessthanjacob lessthanjacob requested review from ritikesh and a team as code owners October 29, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhollinger jhollinger jhollinger approved these changes

@ritikesh ritikesh Awaiting requested review from ritikesh ritikesh is a code owner

Assignees

@lessthanjacob lessthanjacob

Labels
needs code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract Rendering Logic from BaseHelpers
2 participants
@lessthanjacob @jhollinger