soft deletes #22
Closed
soft deletes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
Summary
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Temmmmmo
reviewed
Oct 23, 2024
rating_api/routes/lecturer.py
Outdated
| @@ -188,7 +188,7 @@ async def delete_lecturer( | |||
| for lecturer_user_comment in lecturer_user_comments: | |||
| LecturerUserComment.delete(lecturer_user_comment.id, session=db.session) | |||
|
|
|||
| Lecturer.delete(session=db.session, id=id) | |||
| Lecturer.update(session=db.session, id=id, is_deleted=True) | |||
|
Идея софтделитов в том, что можно, не меняя запросов в базу, ставить нужный флажок вместо реального удаления Опять же, данную логику можно прочитать в базовом декларативном классе Там эта логика уже прописана в методах |
|
Да, и надо nullable=False проставить, а также учесть потом это в миграции, чтобы база не упала |
|
Хоть у нас в базе нет сейчас записей, но все равно |
Temmmmmo
reviewed
Nov 3, 2024
| op.add_column('lecturer', sa.Column('is_deleted', sa.Boolean(), nullable=False, server_default=sa.false())) | ||
| op.add_column( | ||
| 'lecturer_user_comment', sa.Column('is_deleted', sa.Boolean(), nullable=False, server_default=sa.false()) | ||
| ) |
There was a problem hiding this comment.
nullable False
надо тогда докинуть update на старые строки в базе, чтоб не упало
| lecturer_id: Mapped[int] = mapped_column( | ||
| Integer, | ||
| ForeignKey("lecturer.id"), | ||
| primary_join="and_(Comment.lecturer_id==Lecturer.id, not_(Lecturer.is_deleted))", |
There was a problem hiding this comment.
не туда вписал)
lecturer_id это не отношение
надо джоин вписать в lecturer который ниже
|
еще надо добавить тесты) |
|
Еще не доделано |
|
💩 Code linting failed, use |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?