Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ограничения на поля оценок #29

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Ограничения на поля оценок #29

merged 2 commits into from
Nov 7, 2024

Conversation

gitfresnel
Copy link
Contributor

Изменения

Добавил ограничения для полей оценок

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@gitfresnel gitfresnel linked an issue Nov 2, 2024 that may be closed by this pull request
Добавить ограничение на поля оценок #26
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26388%35–36, 44
rating_api/models
   base.py55787%24–27, 45, 53, 74
rating_api/routes
   comment.py662858%28, 34–37, 85–108, 125–128, 142
   exc_handlers.py20290%26, 33
   lecturer.py883165%55, 104–145, 159, 167, 185, 191
rating_api/schemas
   base.py12467%6–9
TOTAL4167981% 

Summary

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 0.768s ⏱️

Temmmmmo
Temmmmmo reviewed Nov 3, 2024
View reviewed changes
rating_api/schemas/models.py Outdated
@classmethod
def validate_mark(cls, value):
if value not in [-2, -1, 0, 1, 2]:
raise ValueError('оценка может принимать только значения: -2, -1, 0, 1, 2')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай свой exception создадим и handler к нему

@Temmmmmo Temmmmmo merged commit cd8370b into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Temmmmmo Temmmmmo Temmmmmo approved these changes

Assignees

@gitfresnel gitfresnel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавить ограничение на поля оценок
2 participants
@gitfresnel @Temmmmmo