Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user_id option to get_comments (delete later) #33

Closed
wants to merge 36 commits into from
Closed

Conversation

zipperman1
Copy link
Contributor

@zipperman1 zipperman1 commented Nov 8, 2024

Изменения

добавил возможность фильтровать комментарии по user_id

Детали реализации

Добавил параметр функции get_comments user_id

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

Copy link

github-actions bot commented Nov 8, 2024

💩 Code linting failed, use black and isort to fix it.

Copy link

github-actions bot commented Nov 8, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26388%35–36, 44
rating_api/models
   base.py55591%24–27, 76
   db.py62592%51–55
rating_api/routes
   comment.py683056%28, 34–37, 88–115, 132–135, 149
   exc_handlers.py20290%26, 33
   lecturer.py901880%52, 106, 116–140, 143, 158, 166, 184, 190
rating_api/schemas
   base.py12467%6–9
TOTAL4407184% 

Summary

Tests Skipped Failures Errors Time
10 0 💤 0 ❌ 0 🔥 0.879s ⏱️

@zipperman1 zipperman1 linked an issue Nov 16, 2024 that may be closed by this pull request
@zipperman1 zipperman1 self-assigned this Nov 16, 2024
@zipperman1
Copy link
Contributor Author

я сделал что то ужасное с этим пр, удалите потом

@zipperman1 zipperman1 changed the title add user_id option to get_comments add user_id option to get_comments (delete later) Nov 18, 2024
@zipperman1 zipperman1 removed their assignment Nov 19, 2024
@Temmmmmo
Copy link
Member

что-то ужасное

@Temmmmmo Temmmmmo closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants