this comment time and create minutes #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💩 Code linting failed, use |
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
DaymasS
requested changes
Dec 4, 2024
rating_api/routes/comment.py
Outdated
| + datetime.timedelta(year=settings.COMMENT_CREATE_FREQUENCY_IN_YEAR) | ||
| - datetime.datetime.now().month | ||
| - datetime.datetime.now().year | ||
| ) | ||
| # Сначала добавляем с user_id, который мы получили при авторизации, | ||
| # в LecturerUserComment, чтобы нельзя было слишком быстро добавлять комментарии | ||
| LecturerUserComment.create(session=db.session, lecturer_id=lecturer_id, user_id=user.get('id')) |
There was a problem hiding this comment.
Создавать запись о комментарии юзера нужно с точностью до месяца
rating_api/routes/comment.py
Outdated
| if datetime.datetime.now().month - user_comment.update_ts < datetime.timedelta( | ||
| month=settings.COMMENT_CREATE_FREQUENCY_IN_MONTH | ||
| ) and datetime.datetime.now().year != datetime.timedelta( | ||
| year=settings.COMMENT_CREATE_FREQUENCY_IN_YEAR |
rating_api/routes/comment.py
Outdated
Comment on lines
33
to
50
| has_create_scope = "rating.comment.import" in [scope['name'] for scope in user.get('session_scopes')] | ||
| if (comment_info.create_ts or comment_info.update_ts) and not has_create_scope: | ||
| raise ForbiddenAction(Comment) | ||
|
|
||
| if not has_create_scope: | ||
| user_comments: list[LecturerUserComment] = ( | ||
| LecturerUserComment.query(session=db.session).filter(LecturerUserComment.user_id == user.get("id")).all() | ||
| ) | ||
| for user_comment in user_comments: | ||
| if datetime.datetime.utcnow() - user_comment.update_ts < datetime.timedelta( | ||
| minutes=settings.COMMENT_CREATE_FREQUENCY_IN_MINUTES | ||
| ): | ||
| raise TooManyCommentRequests( | ||
| dtime=user_comment.update_ts | ||
| + datetime.timedelta(minutes=settings.COMMENT_CREATE_FREQUENCY_IN_MINUTES) | ||
| - datetime.datetime.utcnow() | ||
| ) | ||
|
|
There was a problem hiding this comment.
Не корректное разрешение коллизии. Необходимо сохранить проверку скоупов на задание ts
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Внесены изменения в классы:
Заменены минуты на месяцы
Изменено отображение даты
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?