-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: promote Cooking Appliances to Introduced #33399
base: master
Are you sure you want to change the base?
Darwin: promote Cooking Appliances to Introduced #33399
Conversation
PR #33399: Size comparison from 0d67568 to e7bf019 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
e7bf019
to
3265394
Compare
PR #33399: Size comparison from 0180ee6 to 3265394 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
3265394
to
fe2bbe1
Compare
PR #33399: Size comparison from c8abcfd to fe2bbe1 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
@kiel-apple this PR seems quite old and has merge conflicts. Is it supposed to go in? |
@andy31415 let me take a stab at bringing it back up to date today, I think it won't be awful. |
fe2bbe1
to
9117f83
Compare
PR #33399: Size comparison from 41b6830 to 9117f83 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
and codegen add Microwave + Oven attributes and codegen more Microwave + Oven attributes and codegen add Microwave + Oven commands and codegen add Microwave + Oven command fields and codegen add Microwave + Oven structs and codegen add Microwave + Oven struct fields and codegen add Microwave + Oven events/event fields and codegen add Microwave + Oven enums and codegen add Microwave + Oven enum values and codegen add Microwave + Oven bitmaps / bitmap values and codegen
9117f83
to
f842e75
Compare
PR #33399: Size comparison from 41b6830 to f842e75 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend removing the provisional annotations for things being added; that would also make it clearer what's still marked as provisional.
@bzbarsky-apple thanks for checking the spec, I could have done better there given how long it has been since I opened this |
PR #33399: Size comparison from 41b6830 to dc54e07 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
I still need to go back and do this. Coming soon! |
Continuing the theme of v1.3 promotions. Added comments about
WATTS
and affected provisional bits.