Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate updates to InstaScale test result images #128

Closed
anishasthana opened this issue Jun 8, 2023 · 3 comments
Closed

Automate updates to InstaScale test result images #128

anishasthana opened this issue Jun 8, 2023 · 3 comments

Comments

@anishasthana
Copy link
Member

#120 introduced the ability to update the CodeFlare being used for a test case. The issue however is that when you update the Default value for the deployment, the test cases are outdated.

8c7803e is an example commit fixing the test failures.

We should determine a fix for this. One of the options is to update https://github.com/project-codeflare/codeflare-operator/blob/main/Makefile#L104 to also edit the test results.

@sutaakar
Copy link
Contributor

sutaakar commented Jun 9, 2023

Another option is for tests to fetch the proper image directly from https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/defaults.go and replace a placeholder in test resource.

@astefanutti
Copy link
Contributor

Another option is for tests to fetch the proper image directly from https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/defaults.go and replace a placeholder in test resource.

+1. Ideally we should move away from templates, and use strongly typed input test data.

@astefanutti
Copy link
Contributor

This has become obsolete with #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants